Refresh metadata after creating or deleting a topic #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbruggem
commented
May 21, 2019
jbruggem
force-pushed
the
fix_bug_create_topics
branch
from
9313473 to
ce30307
Compare
|
@jbruggem One question, otherwise just need to rebase and we're good to go. |
jbruggem
force-pushed
the
fix_bug_create_topics
branch
from
35caed0 to
d58620a
Compare
jbruggem
force-pushed
the
fix_bug_create_topics
branch
from
d58620a to
35ce8f2
Compare
jbruggem
force-pushed
the
fix_bug_create_topics
branch
from
35ce8f2 to
df72ac5
Compare
Done, thanks ! |
|
@jbruggem we'd love to have you over on the elixir slack channel #kafkaex - any chance you could join? https://elixir-slackin.herokuapp.com/ |
With pleasure ! Thanks for offering. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects what I believe is a bug in the implementation of
create_topicsanddelete_topics, which leads to stale metadata in the GenServer's state.Indeed, once the creation/deletion of a topic has happened, the metadata in the state of the worker is stale and does not represent the real state of the server.
Hence we should update those metadata when we do that creation or deletion.
I also took the opportunity to rename the callbacks I had added because they were not consistent with the other ones.
Edit: added some fixes to specs (small inconsistencies that were making our dialyzer fail downstream).